Pin version of satori/go.uuid #11
Merged
+19
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 15, 2018 09:27
This reverts commit ad2da3a.
This reverts commit 19d263e.
This reverts commit 18fb139.
Hopefully this should take care of the unreleased breaking changes introduced in `github.com/satori/go.uuid`. For more info about this, see satori/go.uuid#66.
added 5 commits
January 15, 2018 09:38
Vendoring was first introduced in Go 1.5 under an experimental flag.
Previously, one build per env line was triggered.
Closed
lithammer
pushed a commit
that referenced
this pull request
Feb 14, 2018
Given the recent issues with github.com/satori/go.uuid (satori/go.uuid#66), which are still partly unresolved, e.g. its master isn't compatible with us (see #7, #8, #9, 10, #11 and #12). Even though github.com/google/uuid is only at v0.1 and clearly states this: >This package is currently in development and the API may not be stable. > >The API will become stable with v1. I suspect it's a better longterm investment.
lithammer
pushed a commit
that referenced
this pull request
Feb 14, 2018
Given the recent issues with github.com/satori/go.uuid (satori/go.uuid#66), which are still partly unresolved, e.g. its master isn't compatible with us (see #7, #8, #9, 10, #11 and #12). Even though github.com/google/uuid is only at v0.1 and clearly states this: >This package is currently in development and the API may not be stable. > >The API will become stable with v1. I suspect it's a better longterm investment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/satori/go.uuiddoesn't have a released version of the new function signatures introduced by satori/go.uuid@0ef6afb. So pin it to v1.2 for the time being.Fixes #10